Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client close tests #91

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Add client close tests #91

merged 2 commits into from
Nov 10, 2023

Conversation

pdeziel
Copy link
Collaborator

@pdeziel pdeziel commented Nov 10, 2023

This PR adds a unit test and a live test to ensure that events are flushed from the queue when the client is closed.

TODOs and questions

CHECKLIST

  • Is the commit message formatted correctly?
  • Do all of your functions and methods have docstrings?
  • Have you added/updated unit tests where appropriate?
  • Have you run the unit tests using pytest?
  • Is your code style correct (are you using PEP8, pyflakes)?

@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #22053: PyEnsign close doesn't wait for events.

@pdeziel pdeziel requested a review from pdamodaran November 10, 2023 16:59
pdamodaran
pdamodaran approved these changes Nov 10, 2023
View reviewed changes
Copy link

@pdamodaran pdamodaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @pdeziel! Nice work adding the ability to skip the live test if the Ensign server is not available!

@pdeziel pdeziel merged commit 66c82d5 into develop Nov 10, 2023
4 checks passed
@pdeziel pdeziel deleted the sc-22053 branch November 10, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdamodaran pdamodaran pdamodaran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdeziel @pdamodaran