Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object clone #6

Merged
merged 4 commits into from
Oct 27, 2021
Merged

Object clone #6

merged 4 commits into from
Oct 27, 2021

Conversation

DanielSollis
Copy link
Contributor

Update to "refactored versions.go to include tombstones when creating parents" PR based on Benjamin's suggestions.

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #6 (64b98d8) into main (20d04c8) will decrease coverage by 2.52%.
The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   43.68%   41.15%   -2.53%     
==========================================
  Files           5        5              
  Lines         277      277              
==========================================
- Hits          121      114       -7     
- Misses        135      142       +7     
  Partials       21       21              
Impacted Files Coverage Δ
object/object.go 42.10% <0.00%> (-24.57%) ⬇️
versions.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20d04c8...64b98d8. Read the comment docs.

Copy link
Contributor

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for responding to the previous PR comments!

@bbengfort bbengfort merged commit 47b233d into main Oct 27, 2021
@bbengfort bbengfort deleted the objectClone branch October 27, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants