Adds Seek and Prev to Iterator interface #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although primarily a leveldb iterator interface, having Prev in addition to Next is going to be a helpful utility if we can implement it with other engines. The larger requirement is Seek which is absolutely needed for pagination and other advanced iteration. These are primarily a passthrough for leveldb operations, but I've also added some tests for the empty iterator which is not a passthrough.
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
==========================================
+ Coverage 44.10% 46.22% +2.11%
==========================================
Files 6 7 +1
Lines 331 344 +13
==========================================
+ Hits 146 159 +13
Misses 155 155
Partials 30 30
Continue to review full report at Codecov.
|
pdeziel
approved these changes
Dec 8, 2021
|
|
||
| // Seek moves the iterator to the first key/value pair whose key is greater than or | ||
| // equal to the given key. It returns whether such pair exists. | ||
| Seek(key []byte) bool |
There was a problem hiding this comment.
Sounds like this is equivalent to pebble's SeekGE.
There was a problem hiding this comment.
That's a relief - I'm hoping Badger also has something similar!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although primarily a leveldb iterator interface, having Prev in addition
to Next is going to be a helpful utility if we can implement it with
other engines. The larger requirement is Seek which is absolutely needed
for pagination and other advanced iteration. These are primarily a
passthrough for leveldb operations, but I've also added some tests for
the empty iterator which is not a passthrough.