Quick fix to a Seg Fault issue #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #10 +/- ##
=======================================
Coverage 44.10% 44.10%
=======================================
Files 6 6
Lines 331 331
=======================================
Hits 146 146
Misses 155 155
Partials 30 30 Continue to review full report at Codecov.
|
bbengfort
reviewed
Nov 24, 2021
engines/leveldb/leveldb.go
Outdated
| @@ -115,6 +119,10 @@ func (db *LevelDBEngine) Put(key, value []byte, options *opts.Options) (err erro | |||
|
|
|||
| // Thread-unsafe put that is called both by the Transaction and the Store. | |||
| func (db *LevelDBEngine) put(key, value []byte, options *opts.Options) (err error) { | |||
| // Create a default to prevent SigFaults when accessing options{} | |||
| if options == nil { | |||
| options = &opts.Options{} | |||
There was a problem hiding this comment.
Great catch, mind if we use opts.New() to make sure that we have the default options, e.g. the namespace?
There was a problem hiding this comment.
Good idea, updated.
rebeccabilbro
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into Seg-Faults while implementing tests for Benjamin's PR and found this bug.