Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prettier to enforce a consistent style for future contributors #18

Merged
merged 4 commits into from
May 2, 2022

Conversation

rosswintle
Copy link
Owner

This is a copy of #15 but one that I have write access to and can update before merging.

@rosswintle rosswintle merged commit 46147d9 into main May 2, 2022
@rosswintle rosswintle deleted the pr/15-1 branch May 2, 2022 12:28
@rosswintle
Copy link
Owner Author

@GenieTim Do you know enough about Git Hooks to make this run on pre-commit?

I can probably figure it out, but if you have the knowledge and can do it quickly that would be really cool. Don't worry if not though. Really appreciate what you have done here. 🙌

@GenieTim
Copy link
Contributor

GenieTim commented May 2, 2022

I do have some experience, but mostly by using further tools, enabling the hooks to be installed automatically e.g. when installing other dependencies. Prettier has a whole page on possibilities (https://prettier.io/docs/en/precommit.html), my suggestion would be their second one.

I exemplarily set it up in #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants