Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional features #14

Merged
merged 2 commits into from
May 2, 2022
Merged

Conversation

GenieTim
Copy link
Contributor

@GenieTim GenieTim commented May 1, 2022

This PR adds three more features and fixes one small typo. Thank you very much for this project, I like the design and idea very much!

@rosswintle
Copy link
Owner

Hmm... this is my first time accepting contributions like this. So sorry if this is a stupid question:

I can't push some tweaks back to the contribution. Have you got the "Allow edits from maintainers" turned off?

See: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Thanks

@rosswintle rosswintle self-assigned this May 2, 2022
@GenieTim
Copy link
Contributor Author

GenieTim commented May 2, 2022

@rosswintle I am sorry, it seems that checkbox does not exist as I accidentally seem to have forked the repo as an organisation.

See isaacs/github#1681 and https://github.community/t/how-can-we-enable-allow-edits-from-maintainers-by-default/2847/8 and whatwg/html#3881 (comment) as to why I think this is the case.

Would it help if I gave you maintainer access to my fork? Or shall I push and PR again from a private fork?

@rosswintle
Copy link
Owner

Don't worry - I'll fix my end somehow. Thanks!

@rosswintle
Copy link
Owner

Will merge this and then add on #17 (if you want to see how I modified it).

Key things:

Thanks for getting this researched and added!

@rosswintle rosswintle merged commit f677830 into rosswintle:main May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants