Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baselines, fix Line Item targets #64

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Baselines, fix Line Item targets #64

merged 2 commits into from
Apr 24, 2023

Conversation

simsa-st
Copy link
Member

Two fixes of Line Item targets creation.

  • During refactoring, FieldWithGroups changed to immutable and edits to line item ids of tokens were discarded (edits that distributed line item id from individual fields to whole text lines).
  • Sometimes E-LI tag was not assigned to a token even though it should or it could also overwrite B-LI token.

@simsa-st simsa-st requested a review from uricamic April 24, 2023 09:13
Copy link
Member

@uricamic uricamic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simsa-st simsa-st merged commit f5b5f00 into main Apr 24, 2023
@simsa-st simsa-st deleted the sts-fix-li-tagging branch April 24, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants