Addressed TODO in test_local_parameters (#545)

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ros2 · Apr 15, 2024 · 08da25b · 08da25b
1 parent b18cfda
commit 08da25b
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/test_rclcpp/test/test_local_parameters.cpp b/test_rclcpp/test/test_local_parameters.cpp
@@ -63,14 +63,15 @@ TEST_F(test_local_parameters, to_string)
     json_dict.c_str());
 
   pv = rclcpp::Parameter("foo", 2.1);
-  // TODO(tfoote) convert the value to a float and use epsilon test.
   EXPECT_STREQ(
     "{\"name\": \"foo\", \"type\": \"double\", \"value\": \"2.100000\"}",
     std::to_string(pv).c_str());
+  EXPECT_NEAR(pv.as_double(), 2.1, 1e-6f);
   pv = rclcpp::Parameter("foo", 8);
   EXPECT_STREQ(
     "{\"name\": \"foo\", \"type\": \"integer\", \"value\": \"8\"}",
     std::to_string(pv).c_str());
+  EXPECT_EQ(pv.as_int(), 8);
 }
 
 TEST_F(test_local_parameters, local_synchronous)