Overcome 16384 texture size limit for displaying maps #1535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Draft to collect ideas)
When trying to display a map (OccupancyGrid) with an edge greater than 16384, the map displayed is empty.
It seems that the texture rendering fails silently. That specific limit is the OpenGL texture size limit on my machine.
This draft PR fixes it by doubling the Swatch number in that case.
Potential better/proper fix would be to query the system texture size limit.
Any ideas on how to best do that (and multi-platform/arch)?
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information
Tested the limit (and the fix) on multiple 13th Gen x86 intel CPU / iGPU. Potentially this limit is different for other platforms.