Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Quality Level to 1 #532

Merged
merged 2 commits into from
Sep 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions rosidl_runtime_c/QUALITY_DECLARATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ This document is a declaration of software quality for the `rosidl_runtime_c` pa

# rosidl_runtime_c Quality Declaration

The package `rosidl_runtime_c` claims to be in the **Quality Level 2** category.
The package `rosidl_runtime_c` claims to be in the **Quality Level 1** category.

Below are the rationales, notes, and caveats for this claim, organized by each requirement listed in the [Package Requirements for Quality Level 2 in REP-2004](https://www.ros.org/reps/rep-2004.html).

Expand Down Expand Up @@ -116,7 +116,8 @@ A description of how coverage statistics are summarized from this page, can be f

### Performance [4.iv]

`rosidl_runtime_c` does not currently have performance tests.
Most of the features provided by this package are declarations of types and functions, and therefore do not require testing.
The BoundedVector class is benchmarked and the most recent test results can be found [here](http://build.ros2.org/view/Rci/job/Rci__benchmark_ubuntu_focal_amd64/BenchmarkTable/).
ahcorde marked this conversation as resolved.
Show resolved Hide resolved

### Linters and Static Analysis [4.v]

Expand All @@ -137,7 +138,7 @@ It also has several test dependencies, which do not affect the resulting quality

The `rosidl_typesupport_interface` package provides several macros to define the rosidl C typesupport interface.

It is **Quality Level 2**, see its [Quality Declaration document](../rosidl_typesupport_interface/QUALITY_DECLARATION.md).
It is **Quality Level 1**, see its [Quality Declaration document](../rosidl_typesupport_interface/QUALITY_DECLARATION.md).

### Direct Runtime Non-ROS Dependencies [5.iii]

Expand Down
2 changes: 1 addition & 1 deletion rosidl_runtime_c/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ A list of features provided by `rosidl_runtime_c` is available in its [feature d

## Quality Declaration

This package claims to be in the **Quality Level 2** category, see the [Quality Declaration](QUALITY_DECLARATION.md) for more details.
This package claims to be in the **Quality Level 1** category, see the [Quality Declaration](QUALITY_DECLARATION.md) for more details.
5 changes: 3 additions & 2 deletions rosidl_runtime_cpp/QUALITY_DECLARATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ This document is a declaration of software quality for the `rosidl_runtime_cpp`

# rosidl_runtime_cpp Quality Declaration

The package `rosidl_runtime_cpp` claims to be in the **Quality Level 2** category.
The package `rosidl_runtime_cpp` claims to be in the **Quality Level 1** category.

Below are the rationales, notes, and caveats for this claim, organized by each requirement listed in the [Package Requirements for Quality Level 4 in REP-2004](https://www.ros.org/reps/rep-2004.html).

Expand Down Expand Up @@ -114,7 +114,8 @@ A summary of how these statistics are calculated can be found in the [ROS 2 On-b

### Performance [4.iv]

`rosidl_runtime_cpp` does not currently have performance tests.
Most of the features provided by this package are declarations of types and functions, and therefore do not require testing.
The BoundedVector class is benchmarked and the most recent test results can be found [here](http://build.ros2.org/view/Rci/job/Rci__benchmark_ubuntu_focal_amd64/BenchmarkTable/).

### Linters and Static Analysis [4.v]

Expand Down
2 changes: 1 addition & 1 deletion rosidl_runtime_cpp/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ The features provided by `rosidl_runtime_cpp` are documented in its [feature doc

## Quality Declaration

This package claims to be in the **Quality Level 2** category, see the [Quality Declaration](QUALITY_DECLARATION.md) for more details.
This package claims to be in the **Quality Level 1** category, see the [Quality Declaration](QUALITY_DECLARATION.md) for more details.