Overhaul in the rosbag2_transport::TopicFilter class and relevant tests #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
- Before we were using RegexFixture. However, many tests under this test fixture unrelated to the regex. It will be more appropriate and to be consistent to use one test fixture with more generic name. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
- Rationale: 1. Need to avoid using pub/sub and transport layer for testing basic functionalities is it could be avoided. 2. The use cases with filtering messages by topic types already covered in the test_topic_filter.cpp Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
changed the title
MichaelOrlov
requested review from
emersonknapp,
hidmic and
ahcorde
and removed request for
a team
ahcorde
approved these changes
Mar 14, 2024
|
@MichaelOrlov CI is green, feel free to merge it and then I can rebase the other PR |
|
@ahcorde Thanks for a quick review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on the Filter topic by type #1577
Cleanup in topic_filter.cpp and test. Also, add test coverage for the topic_types filter options.
Delete
test_record_topic_types.cppRationale:
functionalities is it could be avoided.
to the
test_topic_filter.cppin the scope of this PR.Add missed
--topic-typesto the error message in therecord.py