Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation about recorder and player creation via composition #1510
Update documentation about recorder and player creation via composition #1510
Changes from all commits
c749c1e
e7ea278
5bad443
b963773
ad3c2b7
1f20d35
39af40a
80de019
3c27d2d
7b8ef10
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if we want to re-explain the benefits from
Composition
in general, which is described in https://docs.ros.org/en/rolling/Concepts/Intermediate/About-Composition.html#ros-2-unified-api good.I would refer to this link, and keep this doc to
how to use player and recorder as components
only in rosbag2 package.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, i just tried with the following. this is not expected result, i may be mistaken?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fujitatomoya It works with
need to use
rosbag2_transport
instead of composition.It seems to be able to use it as you expected with
ros2 component load /ComponentManager composition rosbag2_transport::Player
will need to usecomposition
instead of the${PROJECT_NAME}
hererosbag2/rosbag2_transport/CMakeLists.txt
Lines 73 to 77 in bbbb217
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As regards to the
I have an opposite opinion and think it would be very useful to have a brief introduction with an explanation of why it is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As regards
composition
name. Me and @fujitatomoya think it would be better to userosbag2
name instead ofrosbag2_transport
orcomposition
.i.e. to be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately not easy, if you remember we already discussed during implementation. Current CMake registration macro doesn't allow as far as I understand to change package name when registering components in ament.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/ros2/rclcpp/blob/rolling/rclcpp_components/cmake/rclcpp_components_register_node.cmake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most trivial way to achieve so would be to register the components in
rosbag2
package, adding something like (draft code here):Then build and register it inside
rosbag2
packageCMakeLists.txt
. Still unclear then if some component load tests would need to be moved out fromrosbag2_transport
too then.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roncapat Thanks for the proposal with a workaround in the `rosbag2 package.
I would appreciate it if you could try to make prototype changes for that.
I am sorry, that I don't have the capacity for such an experiment by myself for a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible approach here #1603