Don't dllexport stl containers, instead just the public interface

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
ros2 · Nov 30, 2021 · 277d612 · 277d612
1 parent b390a86
commit 277d612
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/rosbag2_transport/src/rosbag2_transport/topic_filter.cpp b/rosbag2_transport/src/rosbag2_transport/topic_filter.cpp
@@ -79,6 +79,9 @@ TopicFilter::TopicFilter(RecordOptions record_options, bool allow_unknown_types)
   allow_unknown_types_(allow_unknown_types)
 {}
 
+TopicFilter::~TopicFilter()
+{}
+
 std::unordered_map<std::string, std::string> TopicFilter::filter_topics(
   const std::map<std::string, std::vector<std::string>> & topic_names_and_types)
 {

diff --git a/rosbag2_transport/src/rosbag2_transport/topic_filter.hpp b/rosbag2_transport/src/rosbag2_transport/topic_filter.hpp
@@ -27,18 +27,22 @@
 namespace rosbag2_transport
 {
 
-class ROSBAG2_TRANSPORT_PUBLIC TopicFilter
+class TopicFilter
 {
 public:
+  ROSBAG2_TRANSPORT_PUBLIC
   explicit TopicFilter(RecordOptions record_options, bool allow_unknown_types = false);
-  virtual ~TopicFilter() {}
+
+  ROSBAG2_TRANSPORT_PUBLIC
+  virtual ~TopicFilter();
 
   /// Filter all topic_names_and_types via take_topic method, return the resulting filtered set
   /// Filtering order is:
   /// - remove topics with multiple types, unknown type, and hidden topics
   /// - topics list
   /// - exclude regex
   /// - include regex OR "all"
+  ROSBAG2_TRANSPORT_PUBLIC
   std::unordered_map<std::string, std::string> filter_topics(
     const std::map<std::string, std::vector<std::string>> & topic_names_and_types);