Exclude 'performance' test label in rolling jobs #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cottsay
changed the title
|
This is no longer necessary now that performance tests are disabled by default. |
nuclearsandwich
pushed a commit
that referenced
this pull request
Dec 28, 2020
It doesn't build and there are no plans to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to run the performance tests except under specific circumstances. This change excludes them by default from all of the CI and source-based jobs.
This doesn't handle the release jobs at all. Without making the tests disabled by default, I don't see a way to make this happen without changes in Bloom.
Previous discussion was here: ament/ament_cmake#261 (comment)
Discussion during the ROS 2 planning meeting wasn't fruitful either.