Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using rclpy.init context manager. #918

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Switch to using rclpy.init context manager. #918

merged 1 commit into from
Jul 8, 2024

Conversation

clalancette
Copy link
Contributor

This allows us to clean up things substantially, so we can still clean up after ourselves, but use less code doing so.

This is part of ros2/rclpy#1280

@clalancette
Switch to using rclpy.init context manager.
0a3f17d 
This allows us to clean up things substantially, so we
can still clean up after ourselves, but use less code
doing so.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette requested a review from sloretz July 8, 2024 20:44
@clalancette
Copy link
Contributor Author

clalancette commented Jul 8, 2024 •
edited
Loading

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette clalancette merged commit 6e743c8 into rolling Jul 8, 2024
2 of 3 checks passed
@clalancette clalancette deleted the clalancette/rclpy-use-context-manager branch July 8, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clalancette @sloretz