add yaml dump flow style. #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
|
this is supposed to fail since this depends on ros2/rosidl_runtime_py#16 |
|
@iuhilnehc-ynos @audrow could you review this? |
iuhilnehc-ynos
approved these changes
Mar 7, 2022
|
CI:
|
audrow
approved these changes
Mar 7, 2022
|
CI (retry):
|
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
force-pushed
the
feature-20220304-yaml-flow-style
branch
from
d654374 to
6693a5e
Compare
|
CI: i do not have any error in my local environment.
|
|
@audrow @iuhilnehc-ynos CI is green, i will merge this. |
|
@fujitatomoya, could you fix the merge conflicts? PR jobs are broken now, so with green CI we can merge this in. |
|
@audrow i do not think this PR has any merge conflicts? |
|
@fujitatomoya Oops, you're right. I'll merge this in. Thanks for the PR! |
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #680
Signed-off-by: Tomoya Fujita Tomoya.Fujita@sony.com