Add warning and annotation to ros2 node list when there are non-unique nodes
#462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersonknapp
force-pushed
the
emersonknapp/nodelist_annotate_duplicates
branch
from
f11d96f to
cd57c9c
Compare
|
@ros2/aws-oncall - please run this CI job |
|
|
@mjcarroll perhaps, review? |
dabonnie
reviewed
Mar 2, 2020
zmichaels11
reviewed
Mar 2, 2020
emersonknapp
force-pushed
the
emersonknapp/nodelist_annotate_duplicates
branch
from
cd57c9c to
75d398b
Compare
|
@chapulina who should we ask for OSRF-side review on this PR? |
zmichaels11
approved these changes
Mar 2, 2020
3 tasks
|
@hidmic can you review this? |
wjwwood
reviewed
Mar 12, 2020
emersonknapp
force-pushed
the
emersonknapp/nodelist_annotate_duplicates
branch
from
418ea4c to
d26c103
Compare
|
@wjwwood uploaded a simplified version of this PR |
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
force-pushed
the
emersonknapp/nodelist_annotate_duplicates
branch
from
d26c103 to
b66cf91
Compare
wjwwood
approved these changes
Mar 13, 2020
|
I approved the changes, can one of you all do CI again (since there were new changes) and then I (or anyone really) can merge it. |
|
|
Hypothesizing it's flaky preexisting tests, retrying osx build |
|
Hypothesis confirmed, @wjwwood i think we're good to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First half of #453
First half of https://github.com/ros-tooling/aws-roadmap/issues/196
Add a simple warning, and annotate which nodes it applies to, when
ros2 node listlists multiple nodes with the same exact name. Within the "request for design" discussion ros2/design#187, there was confusion expressed about where multiple names come from, whether they are artifacts of the printing process. This at least clears that up a little bit -it does not change the functionality at all.