Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add section about QoS and Option changes for create_{publisher, subscription} #205

Merged
merged 1 commit into from
May 21, 2019
Merged

add section about QoS and Option changes for create_{publisher, subscription} #205

merged 1 commit into from
May 21, 2019

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented May 21, 2019

@wjwwood
add section about QoS and Option changes for create_{publisher, subsc…
738a985 
…ription}

Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood self-assigned this May 21, 2019
@wjwwood
Copy link
Member Author

wjwwood commented May 21, 2019

@jacobperron you might want to consider making a similar one for rclpy? Not sure.

Also, @jubeira do we need an entry here for the changes to parameters in rclpy?

@jacobperron
Copy link
Member

Thanks for the reminder. Added section for rclpy #206

@wjwwood wjwwood merged commit 76508ce into master May 21, 2019
@wjwwood wjwwood deleted the pubsub_qos_and_options_changes_in_dashing branch May 21, 2019 23:28
@jubeira
Copy link
Contributor

jubeira commented May 22, 2019

Also, @jubeira do we need an entry here for the changes to parameters in rclpy?

Sounds like a good idea. I can start with it after I send the PR that enforces the ranges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees

@wjwwood wjwwood

Labels
in review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wjwwood @jacobperron @jubeira