Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker message textures release note #1855

Merged
merged 3 commits into from
Aug 20, 2021
Merged

Conversation

gbalke
Copy link
Contributor

@gbalke gbalke commented Aug 20, 2021

As ros2/common_interfaces#153 is a significant change, release notes are due. Please let me know if this is these notes are in the correct form. I can include images if you think they might aid the notes!

@gbalke gbalke requested review from clalancette and audrow August 20, 2021 19:43
@gbalke gbalke self-assigned this Aug 20, 2021

The embedded ``Meshfile`` message is not yet supported in implementation.

Related PRs: `ros2/common_interfaces#153 <https://github.com/ros2/common_interfaces/pull/153>`_ `ros2/rviz#719 <https://github.com/ros2/rviz/pull/719>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's slightly unusual to put a release note in before the rviz PR is merged, but in this case the change to the message is the big deal. So this is OK with me.

@clalancette clalancette merged commit 5bc8716 into rolling Aug 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the marker_message_update branch August 20, 2021 19:56
mergify bot pushed a commit that referenced this pull request Aug 20, 2021
* Marker message textures release note

(cherry picked from commit 5bc8716)
mergify bot pushed a commit that referenced this pull request Aug 20, 2021
* Marker message textures release note

(cherry picked from commit 5bc8716)
clalancette pushed a commit that referenced this pull request Aug 20, 2021
* Marker message textures release note

(cherry picked from commit 5bc8716)

Co-authored-by: Greg Balke <11024792+gbalke@users.noreply.github.com>
clalancette pushed a commit that referenced this pull request Aug 20, 2021
* Marker message textures release note

(cherry picked from commit 5bc8716)

Co-authored-by: Greg Balke <11024792+gbalke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants