QoS Events and Liveliness #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
Signed-off-by: Miaofei <miaofei@amazon.com>
|
@wjwwood This is ready for review. Can you please update the label? Thank you. |
wjwwood
added
in review
wjwwood
approved these changes
Apr 24, 2019
Signed-off-by: Miaofei <miaofei@amazon.com>
|
Looks like something may have gone wrong here... Make sure you |
wjwwood
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to allow events that occur in the rmw layer related to missed deadlines and liveliness policies to be surfaced up to a user. It adds a new parameter to some existing functions and also adds several new functions in support of the liveliness QoS setting and taking events in general.
Connects to ros2/rmw#171
Related to ros2/design#212