Clarify Data Sharing enabling #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
MiguelCompany
requested changes
Oct 5, 2023
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
MiguelCompany
approved these changes
Oct 5, 2023
fujitatomoya
reviewed
Oct 5, 2023
|
@EduPonz @MiguelCompany btw, do we want to backport #718 and #719 to |
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
I think we definitely should! |
fujitatomoya
approved these changes
Oct 5, 2023
|
@EduPonz @MiguelCompany since this is just a readme change, i will go ahead to merge this w/o CI. |
|
@Mergifyio backport iron humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 8eeb955)
mergify bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 8eeb955) # Conflicts: # README.md
fujitatomoya
pushed a commit
that referenced
this pull request
Oct 5, 2023
fujitatomoya
added a commit
that referenced
this pull request
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#718 introduced documentation for enabling Zero Copy comms. This PR clarifies some points of that documentation.