Add support for PKCS#11 in security files #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IkerLuengo
force-pushed
the
feature/pkcs11_support
branch
2 times, most recently
from
4dd1077
to
8ed228f
Compare
MiguelCompany
force-pushed
the
feature/pkcs11_support
branch
from
8ed228f
to
e2c3f94
Compare
|
I have updated this PR to make it dependent on ros2/rmw_dds_common#66, and just indicate that this RMW supports PKCS#11 |
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2023-02-16/29927/1 |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
force-pushed
the
feature/pkcs11_support
branch
from
e2c3f94
to
e539bfb
Compare
clalancette
approved these changes
Apr 8, 2024
ahcorde
approved these changes
Apr 8, 2024
|
CI for this is in ros2/rmw_dds_common#66 (comment) and ros2/rmw_dds_common#66 (comment) . Going ahead and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the support for PKCS#11 URIs described in ros2/design#319.
Since #544 the generation of the security property values from the files in the enclave relied on
rmw_dds_common::get_security_files. To avoid affecting any other RMW implementation, we had to move the generation of the values back to the RMW itself, adapting it to support several file names for the same security property.For each property, we define an ordered sequence of possible file names that can be used to get that property, and the method to use to get the property value from that file.
*.pemfiles have priority over the new*.p11files.*.pemand*.p7sfiles are processed as always. The attribute value is composed by the prefix prepended to the file path.*.p11files are opened and their content is used as the value of the attribute. It is assumed this content is a single line representing the PKCS#11 URI.Signed-off-by: Iker Luengo ikerluengo@eprosima.com