Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Galactic] Support for SubscriptionOptions::ignore_local_publications #543

Merged
merged 1 commit into from
Jul 12, 2021
Merged

[Galactic] Support for SubscriptionOptions::ignore_local_publications #543

merged 1 commit into from
Jul 12, 2021

Conversation

MiguelCompany
Copy link
Collaborator

Backporting #536 into Galactic

@jamoralp @MiguelCompany
Support for SubscriptionOptions::ignore_local_publications (ros2#536)
2ff8e34 
Signed-off-by: Jose Antonio Moral <joseantoniomoralparras@gmail.com>
@MiguelCompany MiguelCompany mentioned this pull request Jun 22, 2021
Closed
hidmic
hidmic approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Galactic CI up to test_rmw_implementation and test_rclcpp:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic
Copy link
Contributor

hidmic commented Jul 12, 2021

Alright, going in !

@hidmic hidmic merged commit 33c5797 into ros2:master Jul 12, 2021
@hidmic
Copy link
Contributor

hidmic commented Jul 12, 2021

Argh! Wrong base branch...

hidmic added a commit that referenced this pull request Jul 12, 2021
@hidmic
Revert "Support for SubscriptionOptions::ignore_local_publications (#536
fee02c8 
) (#543)"

This reverts commit 33c5797.
hidmic added a commit that referenced this pull request Jul 12, 2021
@hidmic
Revert "Support for SubscriptionOptions::ignore_local_publications (#536
a11e656 
) (#543)"

This reverts commit 33c5797.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
This was referenced Jul 12, 2021
Merged
Merged
@MiguelCompany MiguelCompany deleted the backport/536/galactic branch July 13, 2021 05:13
hidmic added a commit that referenced this pull request Jul 13, 2021
@hidmic
Revert "Support for SubscriptionOptions::ignore_local_publications (#536
fca42bb 
) (#543)" (#548)

This reverts commit 33c5797.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelCompany @hidmic @jamoralp