Indicate missing support for unique network flows #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 9, 2021
added 3 commits
April 1, 2021 12:02
Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
anamud
force-pushed
the
unique_network_flows
branch
from
d807b81 to
586156a
Compare
wjwwood
approved these changes
Apr 2, 2021
Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
wjwwood
approved these changes
Apr 4, 2021
clalancette
pushed a commit
to eboasson/rmw_cyclonedds
that referenced
this pull request
May 18, 2022
* Indicate missing support for unique network flows Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com> * Rename for clarity Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com> * Rename file for consistency Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com> * Uncrustify Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com> Co-authored-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR indicates missing support in rmw_cyclonedds for unique network flows for publishers and subscribers in communicating nodes. Such indication is required for graceful error handling in the ROS2 RMW and above layers.
Associated pull-requests:
Initial contributions stem from Ericsson and eProsima.
Signed-off-by: Ananya Muddukrishna ananya.x.muddukrishna@ericsson.com