Skip to content

Commit

Permalink
Suppress cppcheck unknownMacro (#237)
Browse files Browse the repository at this point in the history
Fast forward to ament/ament_lint#268

This suppresses a defect in `ament_cppcheck` - namely that if a macro is missing, it fails loudly. This is compounded by fact that `ament_cppcheck` does not include all dependent headers, so macros are likely to be missing in the first place.

Signed-off-by: Dan Rose <dan@digilabs.io>
  • Loading branch information
rotu authored and ahcorde committed Oct 15, 2020
1 parent f3016a4 commit aee4305
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,8 @@ repositories:

ros2/rosidl_typesupport_fastrtps/COLCON_IGNORE: *empty_repo
ros2/rmw_fastrtps/COLCON_IGNORE: *empty_repo

ament/ament_lint:
type: git
url: https://github.com/ament/ament_lint.git
version: pull/268/merge
4 changes: 3 additions & 1 deletion .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ jobs:
run: sed -e 's/azure.archive.ubuntu.com/us.archive.ubuntu.com/g' -e t -e d /etc/apt/sources.list | sudo tee /etc/apt/sources.list.d/nonazure.list
- name: Acquire ROS dependencies
uses: ros-tooling/setup-ros@master
- name: Set up git to see all pull requests
run: git config --global --add remote.origin.fetch '+refs/pull/*:refs/remotes/origin/pull/*'
- name: Build and test ROS
uses: ros-tooling/action-ros-ci@0.0.19
with:
Expand All @@ -29,4 +31,4 @@ jobs:
rmw_implementation
vcs-repo-file-url: >
https://raw.githubusercontent.com/ros2/ros2/${{ matrix.rosdistro }}/ros2.repos
https://raw.githubusercontent.com/${{github.repository}}/${{github.sha}}/.github/resources/suppress_other_rmw.repos
https://raw.githubusercontent.com/${{github.repository}}/${{github.sha}}/.github/resources/local.repos

0 comments on commit aee4305

Please sign in to comment.