Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #22 to branch foxy #29

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Backport #22 to branch foxy #29

merged 2 commits into from
Apr 14, 2021

Conversation

asorbini
Copy link
Collaborator

This PR backports relevant changes introduced by #22 to branch foxy.

I have verified locally that the code builds and that things work with a hello world. I'm creating the PR only for bookkeeping purposes.
I will merge it without additional reviews, since Foxy is not supported as Tier 1.

* Use C++ std WaitSets by default

Signed-off-by: Andrea Sorbini <asorbini@rti.com>

* Use Rolling in README's Quick Start

Signed-off-by: Andrea Sorbini <asorbini@rti.com>

* Improved implementation of client::is_service_available for Connext Pro

Signed-off-by: Andrea Sorbini <asorbini@rti.com>

* Only add request header to typecode with Basic req/rep profile

Signed-off-by: Andrea Sorbini <asorbini@rti.com>

* Remove commented/unused code

Signed-off-by: Andrea Sorbini <asorbini@rti.com>

* Avoid topic name validation in get_info functions

Signed-off-by: Andrea Sorbini <asorbini@rti.com>

* Reduce shutdown period to 10ms

Signed-off-by: Andrea Sorbini <asorbini@rti.com>

* Pass HistoryQosPolicy to graph cache

* Reset error string after looking up type support

Signed-off-by: Andrea Sorbini <asorbini@rti.com>

* Remove DDS-based WaitSet implementation

Signed-off-by: Andrea Sorbini <asorbini@rti.com>
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
@asorbini asorbini merged commit 78ff755 into foxy Apr 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the asorbini/backport-22-foxy branch April 14, 2021 00:25
@asorbini asorbini added foxy PR pertaining the Foxy release foxy-backports PR should be backported to Foxy backport The PR backports another PR to an older release labels Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport The PR backports another PR to an older release foxy PR pertaining the Foxy release foxy-backports PR should be backported to Foxy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant