-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update branch master
to support Rolling only
#15
Conversation
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just briefly glanced at it, but what I did look at looks good to me. I think this is the right direction to go in, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also only skimmed the code changes, but README lgtm, and the general pattern of changes lgtm.
I'm happy if CI is happy :)
This PR updates branch
master
to make it buildable only with the Rolling release.The PR removes all "feature flags" from
static_config.hpp
, includingRMW_CONNEXT_RELEASE
and any code meant to support earlier releases.This PR must be merged before creating the next Galactic release in order to be able to create a maintenance branch from the updated
master
.The code was changed assuming the following "feature configuration":
Note to reviewers: It would be great to review these changes but they are somewhat trivial. I'm creating this PR mainly to keep track of them for future reference.