This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Finalize context if and only if it's shutdown #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ivanpauno
reviewed
Jun 22, 2020
| return init(); | ||
| ret = init(); | ||
| if (RMW_RET_OK != ret) { | ||
| if (RMW_RET_OK != rmw_init_options_fini(&context->options)) { |
There was a problem hiding this comment.
this seem unrelated to the PR.
IMO, it should be done in another PR, or in a separate commit.
There was a problem hiding this comment.
That is fair, yeah. I came across leaks and I couldn't help it.
hidmic
force-pushed
the
hidmic/safe-context-finalization
branch
from
ca17974
to
6cf827e
Compare
ivanpauno
approved these changes
Jun 22, 2020
|
CI up to
|
I would run tests up to an upper layer, like test_rclcp, just in case. |
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
Alright, going in. |
ahcorde
pushed a commit
that referenced
this pull request
Oct 8, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde
pushed a commit
that referenced
this pull request
Oct 15, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request, albeit controversial, ensures
rmw_context_fini()fails on a not shutdown context, as its API contract establishes (see ros2/rmw#242).