This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
Replace rosidl_generator_x for rosidl_runtime_x #399
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
I made the change of |
dirk-thomas
reviewed
Mar 24, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
dirk-thomas
approved these changes
Mar 24, 2020
For some reason this failure has appeared in the buildfarm https://ci.ros2.org/job/ci_linux/9920/console:
this is the right patch 28b1b04:
Any idea why is this happening? @dirk-thomas @Karsten1987 ? |
By the way I know this an unrelated change, I can split this new change in a new PR |
Then please do separate it. This has nothing to do with the topic of this PR. |
ahcorde
force-pushed
the
ahcorde/rosidl_runtime
branch
from
April 3, 2020 17:49
28b1b04
to
539cd1c
Compare
Signed-off-by: ahcorde <ahcorde@gmail.com>
dirk-thomas
approved these changes
Apr 7, 2020
In MacOS
Windows
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the changes introduced in this PR ros2/rosidl#442. The full process can be followed here ros2/rosidl#443
rmw_connext
is usingrosidl_generator_c
headers which are located here: rosidl_runtime_cExample os file using these headers
rmw_connext/rmw_connext_dynamic_cpp/src/templates.hpp
Line 22 in 582e69e
Signed-off-by: ahcorde ahcorde@gmail.com