Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publisher/subscription QoS query API documentation. #263

Merged
merged 2 commits into from
Aug 24, 2020

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Aug 20, 2020

Follow-up after 0176872 (#256).

Follow-up after 0176872.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Copy link

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented Aug 24, 2020

Well, it appears that "no allocation" is too strict for our current RMW implementations.

@hidmic
Copy link
Contributor Author

hidmic commented Aug 24, 2020

CI up to test_rmw_implementation:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic hidmic merged commit c9af228 into master Aug 24, 2020
@hidmic hidmic deleted the hidmic/update-pub-sub-qos-docs branch August 24, 2020 21:14
ahcorde pushed a commit that referenced this pull request Oct 13, 2020
Follow-up after 0176872.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde pushed a commit that referenced this pull request Oct 13, 2020
Follow-up after 0176872.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants