Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function to get publisher actual qos settings #169

Merged
merged 2 commits into from
Apr 1, 2019
Merged

Add function to get publisher actual qos settings #169

merged 2 commits into from
Apr 1, 2019

Conversation

ivanpauno
Copy link
Member

@ivanpauno ivanpauno commented Mar 25, 2019 •
edited
Loading

Added rmw_publisher_get_actual_qos function.
This function was proposed in the discussion here: ros2/rclcpp#664 (comment).

I will complete the implementation of the api, following these steps:

@ivanpauno
Added rmw_publisher_get_actual_qos function
97c3a9f 
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno self-assigned this Mar 25, 2019
@ivanpauno ivanpauno requested review from mjcarroll and hidmic March 25, 2019 14:05
@ivanpauno ivanpauno added the in progress Actively being worked on (Kanban column) label Mar 25, 2019
mjcarroll
mjcarroll requested changes Mar 25, 2019
View reviewed changes
@ivanpauno ivanpauno added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Mar 25, 2019
@ivanpauno ivanpauno mentioned this pull request Mar 25, 2019
Merged
@ivanpauno ivanpauno changed the title Add function to get publisher actual qos setting Add function to get publisher actual qos settings Mar 25, 2019
@ivanpauno ivanpauno mentioned this pull request Mar 25, 2019
Merged
This was referenced Mar 25, 2019
Merged
Merged
@ivanpauno
Add RMW_QOS_POLICY_*_UNKNOWN enum value
20d8e69 
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
This was referenced Mar 26, 2019
Merged
Merged
@mm318 mm318 mentioned this pull request Mar 28, 2019
Closed
@ivanpauno
Copy link
Member Author

@mjcarroll @wjwwood All comments have already been solved here. Could you check it again?
Also, RMW_QOS_POLICY_*_UNKNOWN option was added to some enums, as requested here ros2/rmw_fastrtps#267 (comment).

@ivanpauno
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno
Copy link
Member Author

CI again:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit 16d3cf4 into master Apr 1, 2019
@ivanpauno ivanpauno removed the in review Waiting for review (Kanban column) label Apr 1, 2019
@wjwwood wjwwood deleted the ivanpauno/publisher_get_actual_qos branch April 1, 2019 20:54
dabonnie pushed a commit to aws-ros-dev/rmw that referenced this pull request Apr 2, 2019
@ivanpauno @dabonnie
Add function to get publisher actual qos settings (ros2#169)
a95453e 
* Added rmw_publisher_get_actual_qos function

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>

* Add RMW_QOS_POLICY_*_UNKNOWN enum value

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood left review comments

@mjcarroll mjcarroll mjcarroll approved these changes

@hidmic hidmic Awaiting requested review from hidmic

Assignees

@ivanpauno ivanpauno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanpauno @wjwwood @mjcarroll