pass context to wait set, and provide fini function for context #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
This was referenced Jan 10, 2019
|
Please create a stub page for Dashing in ros2_documentation and mention this RMW interface change there so that we keep track of such changes from the beginning. Also @ros2/rmw_implementations FYI. |
|
CI:
|
|
See ros2/ros2_documentation#94 for documentation. |
sloretz
approved these changes
Jan 19, 2019
sloretz
reviewed
Jan 19, 2019
|
CI:
|
dabonnie
pushed a commit
to aws-ros-dev/rmw
that referenced
this pull request
Apr 2, 2019
…#163) * pass context to wait set Signed-off-by: William Woodall <william@osrfoundation.org> * add fini for context Signed-off-by: William Woodall <william@osrfoundation.org> Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #154.
This is not safe for inclusion in Crystal patch releases because it breaks API and adds to API, both of which would require all rmw implementations to be updated.