Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linking on raspbian buster #341

Closed
wants to merge 3 commits into from
Closed

fix linking on raspbian buster #341

wants to merge 3 commits into from

Conversation

BrettRD
Copy link

@BrettRD BrettRD commented Jun 12, 2021

Raspbian buster still doesn't have atomics in the standard symbol table, this is a continuation of #178

discussion: #171 (comment)

This pull request only adds libatomic where it was necessary to build foxy on a pi4 using colcon build --symlink-install --packages-select rcutils

BrettRD added 2 commits June 12, 2021 16:25
Signed-off-by: BrettRD <brettrd@brettrd.com>
@BrettRD BrettRD marked this pull request as draft June 12, 2021 07:40
@BrettRD BrettRD marked this pull request as ready for review June 12, 2021 07:51
@BrettRD
Copy link
Author

BrettRD commented Jun 12, 2021

This change seems a bit too brittle and verbose, pulling foxy latest to merge it turned up a bunch of new linker errors.

Could this be converted into flag that is conditionally added to a linker list and passed to all targets?

@BrettRD BrettRD marked this pull request as draft June 12, 2021 08:30
@BrettRD
Copy link
Author

BrettRD commented Jun 12, 2021

This is the tip of the iceberg, every package that links against rcutils needs extra flags.
After patching both rcutils and rcpputils (in the same way), the build stops at 5 packages failed: class_loader fastrtps libyaml_vendor rcl_logging_spdlog rosidl_runtime_c, all missing the same linker flags, I can only assume there are more in the 122 packages colcon couldn't reach.

I don't have this issue on Armbian, just Raspi OS.
It would be nice to have clean builds on the raspberry pi, but until either it gets fixed upstream (Raspi OS) or the raspi link step goes into ROS2 testing, this patch is going to stop working for pi users very quickly.

I'm going to leave this patch here and pass flags to colcon manually.

@BrettRD BrettRD marked this pull request as ready for review June 12, 2021 09:42
@clalancette clalancette added the more-information-needed Further information is required label Feb 3, 2022
@BrettRD
Copy link
Author

BrettRD commented May 14, 2022

This patch is an ineffective bandaid for a problem with the Raspbian build system.
Closing

see: #171 (comment) for workarounds (and then run a clean build)

@BrettRD BrettRD closed this May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-information-needed Further information is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants