-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check and link against libatomic #172
Conversation
@clalancette @sloretz Can you have a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Downstream packages will need atomic
too. I think this can be done automatically by adding a call to ament_export_library_names()
here.
if(HAVE_LIBATOMICS)
ament_export_library_names(atomic)
endif()
Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>
I got an error with |
Thanks for the PR @christianrauch ! |
Every package using
|
Looks like I forgot to include a repos URL in CI. Re-running to check if it affects the build farm too EDIT: https://ci.ros2.org/view/nightly/job/nightly_linux_debug/1298/consoleText |
This reverts commit 67f064e. Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
* check and link against libatomic (#172) Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Export -latomic linker flag Signed-off-by: Shane Loretz <sloretz@openrobotics.org> Co-authored-by: Christian Rauch <Rauch.Christian@gmx.de>
* check and link against libatomic (#172) Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Export -latomic linker flag Signed-off-by: Shane Loretz <sloretz@openrobotics.org> Co-authored-by: Christian Rauch <Rauch.Christian@gmx.de> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
* check and link against libatomic (#172) Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Export -latomic linker flag Signed-off-by: Shane Loretz <sloretz@openrobotics.org> Co-authored-by: Christian Rauch <Rauch.Christian@gmx.de> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Christian Rauch <Rauch.Christian@gmx.de>
Link against libatomic. Fixes #171 .