Add utility function to get the size of a file #28
Conversation
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
piraka9011
force-pushed
the
allabana/file_size
branch
from
15cb401 to
150d60b
Compare
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
|
@thomas-moulard FYI, @zmichaels11 Take a look at some of the |
|
We should probably clean both IMHO. |
Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me>
Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me>
If you have any comments/suggestions tho lmk! Most likely I will introduce the Windows and Linux fixes separately. |
|
After discussion with @emersonknapp , this may not be the best approach, rather, create a wrapper around the C++17 FileSystem API with CMake linkers to C bindings. |
There was a problem hiding this comment.
@piraka9011 The TCHAR code seems to instantiate a variable w/o using it - could you PTAL?
| src/find_library.cpp | ||
| src/filesystem_helper.cpp) |
| // Increase length by two to add the double null termination | ||
| const auto char_length = strlen(text.c_str()); | ||
| const auto new_text = std::make_unique<TCHAR[]>(char_length + 2); | ||
| // memcpy(temp_dir, text.c_str(), length); |
| void remove_directory_recursively(const std::string & directory_path) | ||
| { | ||
| #ifdef _WIN32 | ||
| const auto null_terminated_directory = create_double_null_terminated_tchar(directory_path); |
|
Resolved by ros2/rcutils#197 |
Changes
std::fs::file_sizeshim.file_size().Signed-off-by: Anas Abou Allaban allabana@amazon.com