Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashing backport] Add function 'find_and_replace' #17

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

jacobperron
Copy link
Member

Backport #13

* Add function 'find_and_replace'

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Fix spelling

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Add shortcut for find == replace

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Template on std::basic_string

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* changed find_and_replace to accept literals using magic 🌈✨

Signed-off-by: William Woodall <william@osrfoundation.org>

* Fix lint

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron merged commit 41476b5 into dashing Jul 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/backport_13 branch July 26, 2019 17:08
@jacobperron jacobperron changed the title Add function 'find_and_replace' [dashing backport] Add function 'find_and_replace' Jul 30, 2019
@jacobperron
Copy link
Member Author

@ros2/aws-robotics-code-owners

In preparation for Dashing patch release 2, it would be great if the dashing branch could be tagged and released so this change is included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants