Make use of rcutils log severity defined enum instead of duplicating code #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
|
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
hidmic
approved these changes
Nov 27, 2019
ivanpauno
approved these changes
Nov 27, 2019
|
The patch is fine for now. I am still worried that this will get us further away from being able to import |
Yes, I remember the ticket and the discussions. Thanks for bumping that one up. I also recall that most variations trying to circumvent the problem weren't great either. It'd be good if we could spend the time to really solve the problem i.e. C extensions need not be special, it's a trap to make them so. |
suab321321
pushed a commit
to suab321321/rclpy
that referenced
this pull request
Jan 31, 2020
…code (ros2#468) * Make use of rcutils log severity defined enum instead of duplicating code Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com> Signed-off-by: AbhinavSingh <singhabhinav9051571833@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #458. Remove log severity hard coded and copied values from rcutils