Adjust python usage of the type_description service API #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujitatomoya
requested changes
Oct 29, 2023
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
mjcarroll
force-pushed
the
mjcarroll/fini_service
branch
from
02e459c to
21abfb6
Compare
fujitatomoya
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ros2/rcl#1112, the API is updated to populate the service structure, rather than
init,get, andfini. This updates rclpy to use the new API pattern.