Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fini arguments passed to rcl_node_init() #468

Merged
merged 2 commits into from
May 1, 2018

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented May 1, 2018

Always finalize arguments because caller is responsible for freeing memory used by node options.

replaces #467

connects to ros2/rcl#231

@sloretz sloretz added the in progress Actively being worked on (Kanban column) label May 1, 2018
@sloretz sloretz self-assigned this May 1, 2018
@sloretz sloretz changed the title Rcl node init arguments copy Fini arguments passed to rcl_node_init() May 1, 2018
@sloretz sloretz merged commit 7cd8429 into master May 1, 2018
@sloretz sloretz deleted the rcl_node_init_arguments_copy branch May 1, 2018 19:59
@sloretz sloretz removed the in progress Actively being worked on (Kanban column) label May 1, 2018
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
* introduce ros2 bag list <plugins>

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants