add spin_node_once() #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this function take a blocking boolean? It could be passed to Either way looks good to me. |
|
+1 |
|
I updated the signature of |
|
+1 |
1 similar comment
|
+1 |
mauropasse
pushed a commit
to mauropasse/rclcpp
that referenced
this pull request
Feb 26, 2021
use void * to pass executor ptr
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
* Add tests for rcl_wait and fix for timers
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* Display bag summary using `ros2 bag info` * Improve process execution helper to handle the working directory * Use metadata filename in sqlite storage to determine database name * ros2GH-109 Write metadata file on Windows by hand - On Windows, the process is killed hard and thus does not write its metadata file - Since this is an issue with the test setup that seems very hard to fix, for now we just write the metadata file on our own * Remove empty bag folder if record gets aborted and no files are created - For example is neither --all nor topics are specified or if a non exsisting storage plugin is specified * Fail gracefully if a runtime error occurs when trying to record or play - For example if the storage plugin specified by the user at record does not exist * Log error in case of failing when loading metadata, and minor refactoring * Add comment to version field * Allow rosbag2 info without yaml file Currently only supported on rosbag2 side: - Allow passing a storage identifier to rosbag2::Info() - If a yaml file exists, read info from yaml - If no yaml file exists and a storage identifier was passed open storage and read info directly * ros2GH-7 Don't try to read database name from metadata file when opening with ReadWrite io_flag - This avoids the logging of a 'failed to read metadata' error when recording a new bag * ros2GH-7 Rename 'storage format' into 'serialization format' -In this way it is not confused with the storage id (e.g. sqlite3) * ros2GH-7 Improve failure conditions * ros2GH-7 Cleanup of superfluous forward declarations * ros2GH-7 Further improve exception handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is being used by ros2/ros1_bridge#1.
Please review.