Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings on Windows. #2692

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Fix warnings on Windows. #2692

merged 1 commit into from
Dec 3, 2024

Conversation

clalancette
Copy link
Contributor

@clalancette clalancette commented Dec 3, 2024 •
edited
Loading

For reasons I admit I do not understand, the deprecation warnings for StaticSingleThreadedExecutor on Windows happen when we construct a shared_ptr for it in the tests. If we construct a regular object, then it is fine. Luckily this test does not require a shared_ptr, so just make it a regular object here, which fixes the warning.

While we are in here, make all of the tests camel case to be consistent.

This should fix the warnings introduced by #2683 . @jmachowinski @fujitatomoya FYI

@clalancette
Fix warnings on Windows.
e1c8b59 
For reasons I admit I do not understand, the deprecation
warnings for StaticSingleThreadedExecutor on Windows
happen when we construct a shared_ptr for it in the tests.
If we construct a regular object, then it is fine.  Luckily
this test does not require a shared_ptr, so just make it
a regular object here, which rixes the warning.

While we are in here, make all of the tests camel case to
be consistent.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor Author

Pulls: #2692
Gist: https://gist.githubusercontent.com/clalancette/c93b0541e50656956582ac2648800c27/raw/e16918165506e97bbce2fd15ddaa084ff5bae568/ros2.repos
BUILD args: --packages-up-to rclcpp
TEST args: --packages-select rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14898

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya reviewed Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@fujitatomoya fujitatomoya merged commit 3310f9e into rolling Dec 3, 2024
3 checks passed
@fujitatomoya
Copy link
Collaborator

@Mergifyio backport jazzy

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 3, 2024 •
edited
Loading

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 3, 2024
@clalancette @mergify
Fix warnings on Windows. (#2692)
e419ce7 
For reasons I admit I do not understand, the deprecation
warnings for StaticSingleThreadedExecutor on Windows
happen when we construct a shared_ptr for it in the tests.
If we construct a regular object, then it is fine.  Luckily
this test does not require a shared_ptr, so just make it
a regular object here, which rixes the warning.

While we are in here, make all of the tests camel case to
be consistent.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 3310f9e)

# Conflicts:
#	rclcpp/test/rclcpp/executors/test_executors.cpp
@mergify mergify bot mentioned this pull request Dec 3, 2024
Merged
@clalancette clalancette mentioned this pull request Dec 3, 2024
Merged
@clalancette clalancette deleted the clalancette/fix-windows-warnings branch December 3, 2024 13:20
ahcorde pushed a commit that referenced this pull request Dec 4, 2024
@mergify @clalancette @fujitatomoya
Fix warnings on Windows. (backport #2692) (#2694)
e217532 
* Fix warnings on Windows. (#2692)

For reasons I admit I do not understand, the deprecation
warnings for StaticSingleThreadedExecutor on Windows
happen when we construct a shared_ptr for it in the tests.
If we construct a regular object, then it is fine.  Luckily
this test does not require a shared_ptr, so just make it
a regular object here, which rixes the warning.

While we are in here, make all of the tests camel case to
be consistent.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 3310f9e)

# Conflicts:
#	rclcpp/test/rclcpp/executors/test_executors.cpp

* resolve backport conflict.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

---------

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
HarunTeper pushed a commit to HarunTeper/rclcpp that referenced this pull request Dec 9, 2024
@clalancette @HarunTeper
Fix warnings on Windows. (ros2#2692)
84207f6 
For reasons I admit I do not understand, the deprecation
warnings for StaticSingleThreadedExecutor on Windows
happen when we construct a shared_ptr for it in the tests.
If we construct a regular object, then it is fine.  Luckily
this test does not require a shared_ptr, so just make it
a regular object here, which rixes the warning.

While we are in here, make all of the tests camel case to
be consistent.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: HarunTeper <harun.teper@tu-dortmund.de>
HarunTeper pushed a commit to HarunTeper/rclcpp that referenced this pull request Dec 9, 2024
@clalancette @HarunTeper
Fix warnings on Windows. (ros2#2692)
c962f5e 
For reasons I admit I do not understand, the deprecation
warnings for StaticSingleThreadedExecutor on Windows
happen when we construct a shared_ptr for it in the tests.
If we construct a regular object, then it is fine.  Luckily
this test does not require a shared_ptr, so just make it
a regular object here, which rixes the warning.

While we are in here, make all of the tests camel case to
be consistent.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: HarunTeper <harun.teper@tu-dortmund.de>
HarunTeper pushed a commit to HarunTeper/rclcpp that referenced this pull request Dec 9, 2024
@clalancette @HarunTeper
Fix warnings on Windows. (ros2#2692)
fa95b39 
For reasons I admit I do not understand, the deprecation
warnings for StaticSingleThreadedExecutor on Windows
happen when we construct a shared_ptr for it in the tests.
If we construct a regular object, then it is fine.  Luckily
this test does not require a shared_ptr, so just make it
a regular object here, which rixes the warning.

While we are in here, make all of the tests camel case to
be consistent.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
HarunTeper pushed a commit to HarunTeper/rclcpp that referenced this pull request Mar 3, 2025
@clalancette @HarunTeper
Fix warnings on Windows. (ros2#2692)
d83c4ed 
For reasons I admit I do not understand, the deprecation
warnings for StaticSingleThreadedExecutor on Windows
happen when we construct a shared_ptr for it in the tests.
If we construct a regular object, then it is fine.  Luckily
this test does not require a shared_ptr, so just make it
a regular object here, which rixes the warning.

While we are in here, make all of the tests camel case to
be consistent.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: HarunTeper <harun.teper@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya left review comments

@jmachowinski jmachowinski jmachowinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clalancette @fujitatomoya @jmachowinski