Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composition_interfaces #60

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Add composition_interfaces #60

merged 1 commit into from
Jan 29, 2019

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Jan 24, 2019

This adds services defined in ros2/design#206 to a new package called composition_interfaces. The intent is both launch_ros and container packages (rclcpp_composition?) would use the services from this package to interact.

@sloretz sloretz added the in review Waiting for review (Kanban column) label Jan 24, 2019
@sloretz sloretz self-assigned this Jan 24, 2019
@sloretz
Copy link
Contributor Author

sloretz commented Jan 24, 2019

CI (testing only composition_interfaces)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mjcarroll
Copy link
Member

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic
Copy link
Contributor

hidmic commented Jan 25, 2019

@sloretz any reason why we have all those missing newlines at the end?

@sloretz
Copy link
Contributor Author

sloretz commented Jan 25, 2019

@hidmic I just switched to a different code editor. I guess the new one doesn't add \n to the last line of a file by default.

@sloretz sloretz merged commit 20bb1e5 into master Jan 29, 2019
@sloretz sloretz deleted the composition_interfaces branch January 29, 2019 15:39
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants