Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[foxy backport] Add check to rcl_node_options_copy for invalid arg (#671) + add tests (#668) #697

Merged
merged 2 commits into from
Jun 24, 2020
Merged

[foxy backport] Add check to rcl_node_options_copy for invalid arg (#671) + add tests (#668) #697

merged 2 commits into from
Jun 24, 2020

Commits on Jun 23, 2020

  1. Add tests for rcl package (#668) 

    * Add tests for node_options usage
* Add tests for copying options arguments
* Add bad argument tests for wait sets
* Add tests for wait_set_get_allocator function
* Add test for rcl_take_response function
* Change take_request to match take_response without info
* Change specific test for sequence_number
* Add tests for client take failed
* Remove tests already done in nominal setup
* Add bad arguments tests
* Add test for init returning BAD_ALLOC
* Add test for client get_options
* Add test for already init client
* Add bad argument tests
* Add basic test get_default_domain_id
* Add test for rmw to rcl return code function
* Add test for get_localhost_only
* Add tests for localhost expected usage
* Address peer review comments
* Add test for env variable leading to ULONG_MAX
* Change return values to enum in test
* Fix rcl_get_localhost_only return value
* Address peer review comments
* Add unexpected value to get_localhost
* Add reset_rcl_error after expected fails

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545 @jacobperron
    Blast545 authored and jacobperron committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    8be6557 View commit details
    Browse the repository at this point in the history

  2. Add check rcl_node_options_copy invalid out (#671) 

    * Add bug fix for rcl_node_options_copy

If copy source has options->arguments.impl==NULL
this will cause problem when calling fini
on options dst

* Add test case for bug fix
* Return error when passing not init object
* Remove unexpected usage test
* Init options with non empty arguments

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545 @jacobperron
    Blast545 authored and jacobperron committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    9d6e8e3 View commit details
    Browse the repository at this point in the history