Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check rcl_node_options_copy invalid out #671

Merged
merged 5 commits into from
Jun 19, 2020
Merged

Add check rcl_node_options_copy invalid out #671

merged 5 commits into from
Jun 19, 2020

Commits on Jun 10, 2020

  1. Add bug fix for rcl_node_options_copy 

    If copy source has options->arguments.impl==NULL
this will cause problem when calling fini
on options dst

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    fbb1a06 View commit details
    Browse the repository at this point in the history

  2. Add test case for bug fix 

    Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    6f289e5 View commit details
    Browse the repository at this point in the history

  3. Return error when passing not init object 

    Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    ffd53d8 View commit details
    Browse the repository at this point in the history

  4. Remove unexpected usage test 

    Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    551c445 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2020

  1. Init options with non empty arguments 

    Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    3b56b26 View commit details
    Browse the repository at this point in the history