Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to one Participant per Context #515

Merged
merged 30 commits into from
Apr 3, 2020
Merged

Switch to one Participant per Context #515

merged 30 commits into from
Apr 3, 2020

Commits on Mar 27, 2020

  1. Rename security_directory.* to security.* 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    31d3acc View commit details
    Browse the repository at this point in the history

  2. Switch to one participant per context 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Fix test

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Addressed comments

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Increase test_graph timeout

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    f9aa67e View commit details
    Browse the repository at this point in the history

  3. Add context name and namespace, allow configuring security directory … 

    …with context name

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Address peer review comments

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Address peer review comments

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Correct wrong RMW_RET_OK to RCL_RET_OK

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    7009480 View commit details
    Browse the repository at this point in the history

  4. Only destroy security options when they were created 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    d160c8d View commit details
    Browse the repository at this point in the history

  5. Avoid mentioning node in security.* 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    d8cd5d5 View commit details
    Browse the repository at this point in the history

  6. Fix test_info_by_topic 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    9c5d594 View commit details
    Browse the repository at this point in the history

  7. Add const where possible 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    61acc14 View commit details
    Browse the repository at this point in the history

  8. Please linters 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    859929c View commit details
    Browse the repository at this point in the history

  9. Address peer review comments 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    48864b8 View commit details
    Browse the repository at this point in the history

  10. Support overriding the security directory 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    deb4f94 View commit details
    Browse the repository at this point in the history

  11. Rename test_security_directory to test_security 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    08653d0 View commit details
    Browse the repository at this point in the history

  12. Reenable tests for security directory override 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    9134305 View commit details
    Browse the repository at this point in the history

  13. Add test case for 'rcl_get_security_options_from_environment' 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    b4fe23a View commit details
    Browse the repository at this point in the history

  14. Delete unused local variable 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    f7d9406 View commit details
    Browse the repository at this point in the history

  15. Address peer review comments 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    717c444 View commit details
    Browse the repository at this point in the history

  16. Latest update after discussion about supporting sros2 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    ea4575f View commit details
    Browse the repository at this point in the history

  17. Delete namespace from security root path functions. Delete security d… 

    …irectory prefix lookup strategy. Add context name validation

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    4e48a4d View commit details
    Browse the repository at this point in the history

  18. Delete unused headers 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    8680864 View commit details
    Browse the repository at this point in the history

  19. Correct rebasing error 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    0fe8a0b View commit details
    Browse the repository at this point in the history

  20. Correct error in comment 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    c4807ba View commit details
    Browse the repository at this point in the history

  21. Naming: replace context_name with security_context 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    7f1b51e View commit details
    Browse the repository at this point in the history

  22. Addrees peer review comments 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    eb2e187 View commit details
    Browse the repository at this point in the history

  23. Please linters 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    daad168 View commit details
    Browse the repository at this point in the history

  24. Replace RCL_CONTEXT_NAME_* with RCL_SECURITY_CONTEXT_NAME_* 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    50035e3 View commit details
    Browse the repository at this point in the history

  25. * Use security_context instead of context_name everywhere 

    * Add rcl_get_nodes_names_with_security_contexts

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    b4d4738 View commit details
    Browse the repository at this point in the history

  26. Please linters 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    4c239f6 View commit details
    Browse the repository at this point in the history

  27. Address peer review comments 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    86da265 View commit details
    Browse the repository at this point in the history

  28. Address more reviewers' comments 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    46322dc View commit details
    Browse the repository at this point in the history

  29. Address reviewer comment 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    000e2e3 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. Address peer review comments 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    77aad14 View commit details
    Browse the repository at this point in the history