Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support parameter overrides and remap rules flags on command line #483

Merged
merged 13 commits into from
Aug 26, 2019
Merged

Support parameter overrides and remap rules flags on command line #483

merged 13 commits into from
Aug 26, 2019

Commits on Aug 8, 2019

  1. Support rcl_params_t copies. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    bd41494 View commit details
    Browse the repository at this point in the history

  2. Parse parameter overrides from command line. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    32e5a4c View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2019

  1. Parameter overrides' tests passing. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    cbe9af7 View commit details
    Browse the repository at this point in the history

  2. Test rcl_yaml_node_struct_copy() function 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    09fa3c8 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2019

  1. Export rcl_yaml_param_parser as rcl dependency. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    b600446 View commit details
    Browse the repository at this point in the history

  2. Zero initialize parameter overrides before rcl arguments copy. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    4d53b06 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2019

  1. Initialize local variables early enough. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    be90f4c View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2019

  1. Simplify rcl package.xml 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 14, 2019
    Configuration menu
    Copy the full SHA
    abf3391 View commit details
    Browse the repository at this point in the history

  2. Assert arguments sanity in rcl args parsing internal functions. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 14, 2019
    Configuration menu
    Copy the full SHA
    c4a2a0f View commit details
    Browse the repository at this point in the history

  3. Extend rcl_yaml_param_parser tests to all parameter types. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 14, 2019
    Configuration menu
    Copy the full SHA
    37e1569 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2019

  1. Address peer review comments. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    ac845e9 View commit details
    Browse the repository at this point in the history

  2. Support --remap/-r flags. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    6bb553c View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2019

  1. Please cpplint 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    e51c05b View commit details
    Browse the repository at this point in the history