Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to initialize the bool field. #426

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Make sure to initialize the bool field. #426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions rcl/test/rcl/test_service.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,12 @@ TEST_F(CLASSNAME(TestServiceFixture, RMW_IMPLEMENTATION), test_service_nominal)
// Initialize a request.
test_msgs__srv__Primitives_Request client_request;
test_msgs__srv__Primitives_Request__init(&client_request);
// TODO(clalancette): the C __init methods do not initialize all structure
// members, so the numbers in the fields not explicitly set is arbitrary.
// The CDR deserialization in Fast-CDR requires a 0 or 1 for bool fields,
// so we explicitly initialize that even though we don't use it. This can be
// removed once the C __init methods initialize all members by default.
client_request.bool_value = false;
client_request.uint8_value = 1;
client_request.uint32_value = 2;
int64_t sequence_number;
Expand Down