Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

escalate RCL_RET_ACTION_xxx to 40XX. #1191

Merged
merged 1 commit into from
Sep 24, 2024
Merged

escalate RCL_RET_ACTION_xxx to 40XX. #1191

merged 1 commit into from
Sep 24, 2024

Conversation

fujitatomoya
Copy link
Collaborator

closes #1190

this breaks ABI, we cannot backport this.

@fujitatomoya
escalate RCL_RET_ACTION_xxx to 40XX.
fb0bb5f 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
fujitatomoya commented Sep 24, 2024
View reviewed changes
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these return codes are used in rclcpp and rclpy, so this breaks the ABI.

@fujitatomoya
Copy link
Collaborator Author

Pulls: #1191
Gist: https://gist.githubusercontent.com/fujitatomoya/64c954488360ee36939cd5ce0e7ee24c/raw/2a299124618a321cee350b268c24e0476519b06c/ros2.repos
BUILD args: --packages-above-and-dependencies rcl rcl_action
TEST args: --packages-above rcl rcl_action
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14601

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

clalancette
clalancette approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. Once we merge this in, we should do a release of this into Rolling right away to see if anything downstream breaks.

@ahcorde ahcorde merged commit 1e565d5 into rolling Sep 24, 2024
3 checks passed
@ahcorde ahcorde deleted the fujitatomoya/return-code-confliction branch September 24, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

@ivanpauno ivanpauno Awaiting requested review from ivanpauno ivanpauno is a code owner

@wjwwood wjwwood Awaiting requested review from wjwwood wjwwood is a code owner

@ahcorde ahcorde Awaiting requested review from ahcorde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rcl event specific ret codes conflict with rcl action specific ret codes
3 participants
@fujitatomoya @clalancette @ahcorde