Skip some event tests on rmw_zenoh #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
fujitatomoya
approved these changes
Sep 4, 2024
|
Pulls: #1180
|
Yadunund
reviewed
Sep 26, 2024
| @@ -866,6 +891,10 @@ void event_callback(const void * user_data, size_t number_of_events) | |||
| */ | |||
| TEST_F(TestEventFixture, test_pub_matched_unmatched_event) | |||
| { | |||
| if (std::string(rmw_get_implementation_identifier()).find("rmw_zenoh_cpp") == 0) { | |||
There was a problem hiding this comment.
@ahcorde this event should we supported in rmw_zenoh.
| @@ -977,6 +1006,10 @@ TEST_F(TestEventFixture, test_pub_matched_unmatched_event) | |||
| */ | |||
| TEST_F(TestEventFixture, test_sub_matched_unmatched_event) | |||
| { | |||
| if (std::string(rmw_get_implementation_identifier()).find("rmw_zenoh_cpp") == 0) { | |||
There was a problem hiding this comment.
@ahcorde this event should we supported in rmw_zenoh.
| @@ -1178,6 +1211,10 @@ TEST_F(TestEventFixture, test_pub_previous_matched_event) | |||
|
|
|||
| TEST_F(TestEventFixture, test_sub_previous_matched_event) | |||
| { | |||
| if (std::string(rmw_get_implementation_identifier()).find("rmw_zenoh_cpp") == 0) { | |||
There was a problem hiding this comment.
@ahcorde this event should we supported in rmw_zenoh.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some events are still not supported on
rmw_zenoh_cppwhich makes CI to show a failure test. This PR skip the test when the event is not well initialized or if the feature is not implemented the tests is completely skipped.