Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return service from node_type_description_service_init #1112

Merged
merged 5 commits into from
Oct 30, 2023
Merged

Return service from node_type_description_service_init #1112

merged 5 commits into from
Oct 30, 2023

Commits on Oct 26, 2023

  1. Make the fini of the type description service explicit 

    This makes the caller responsible for cleaning up the service.

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    43dfecc View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Remove fini and get methods 

    Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    3d215eb View commit details
    Browse the repository at this point in the history

  2. Update tests 

    Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    90888a2 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. Update documentation based on reviewer feedback 

    Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    6f7da3a View commit details
    Browse the repository at this point in the history

  2. Fix and document test 

    Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    25174df View commit details
    Browse the repository at this point in the history